Skip to content

Simplify down to one stack.yaml #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

michaelpj
Copy link
Collaborator

As discussed on Matrix.

Since we don't use this for user installation, nor for testing multiple
versions of GHC (we have Haskell-CI based on cabal for that), the only
use of this is to provide a dev setup for stack users. As such, one
stack.yaml should be sufficient.

I checked and stack build still succeeds.

As discussed on Matrix.

Since we don't use this for user installation, nor for testing multiple
versions of GHC (we have Haskell-CI based on `cabal` for that), the only
use of this is to provide a dev setup for stack users. As such, one
`stack.yaml` should be sufficient.
@michaelpj michaelpj requested a review from jneira December 15, 2021 13:57
@michaelpj
Copy link
Collaborator Author

michaelpj commented Dec 15, 2021

Bumping the install-nix-action version seems to fix the nix issue, the bump is in #378, I'll rebase this after that's in.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! the remaining stack.yaml is almost perfect

flags: {}
extra-package-dbs: []
nix:
packages: [icu]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, how clean it is! Thanks!

@michaelpj
Copy link
Collaborator Author

It's only clean because 8.10 is so old now that lots of packages have got into stackage :P

@jneira
Copy link
Member

jneira commented Dec 15, 2021

...and LSP packages and their deps live in stackage

@mergify mergify bot merged commit 8a840f7 into haskell:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants