fix: hide navigation header if there is nothing underneath #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8bf3da5.
itssharmasandeep
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 85.06% 85.07% +0.01%
==========================================
Files 820 820
Lines 16863 16878 +15
Branches 2190 2195 +5
==========================================
+ Hits 14344 14359 +15
Misses 2488 2488
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Jul 26, 2021
| }, | ||
| { | ||
| type: NavItemType.Link, | ||
| icon: 'icon', |
There was a problem hiding this comment.
Shouldn't this show up since there is not feature flag applied?
anandtiwary
reviewed
Jul 26, 2021
| @@ -87,6 +91,26 @@ export class NavigationListComponent { | |||
| return this.collapsed ? IconType.TriangleRight : IconType.TriangleLeft; | |||
| } | |||
|
|
|||
| public shouldShowHeader(index: number): Observable<boolean> { | |||
anandtiwary
reviewed
Jul 26, 2021
| return isEmpty(features.flat()) | ||
| ? of(false) | ||
| : combineLatest( | ||
| features |
There was a problem hiding this comment.
You shouldn't need to check feature flag state every time. One resolution per browser refresh is enough. Then we can just share the same result throughout (till another browser refresh)
3 tasks
|
closing this, please check #1035 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Local testing done.
Checklist: