fix: hide navigation header if nothing underneath #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8bf3da5.
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 85.06% 85.09% +0.02%
==========================================
Files 820 821 +1
Lines 16865 16898 +33
Branches 2190 2196 +6
==========================================
+ Hits 14346 14379 +33
Misses 2488 2488
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Jul 28, 2021
anandtiwary
reviewed
Jul 28, 2021
| @@ -11,7 +11,7 @@ import { NavItemLinkConfig } from '../navigation-list.component'; | |||
| template: ` | |||
| <ht-link *ngIf="this.config" [paramsOrUrl]="buildNavigationParam | htMemoize: this.config"> | |||
| <div | |||
| *htIfFeature="this.config.features | htFeature as featureState" | |||
| *htIfFeature="this.config.featureState$ | async as featureState" | |||
There was a problem hiding this comment.
ooh.. @itssharmasandeep I think we still need to apply htFeature here
There was a problem hiding this comment.
htFeature takes the features which are string[] and convert this to featureState
I am converting this to featureState in the service itself and pass here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hide navigation header if there is nothing underneath
Testing
Local Testing done.
Checklist:
There was some problem with #1024 so created this new one.