Skip to content

feat: adding compact style #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2021
Merged

feat: adding compact style #961

merged 3 commits into from
Jun 30, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jun 30, 2021

Description

Allowing multiple styles and adding Compact style in the Bar Gauge

Testing

Visual Testing

-Regular View:

image

-Compact View:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from anandtiwary June 30, 2021 15:41
@palbizu palbizu requested a review from a team as a code owner June 30, 2021 15:41
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #961 (37fea83) into main (8206517) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files         812      812           
  Lines       16737    16738    +1     
  Branches     2164     2164           
=======================================
+ Hits        14234    14235    +1     
  Misses       2472     2472           
  Partials       31       31           
Impacted Files Coverage Δ
...shared/components/bar-gauge/bar-gauge.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8206517...37fea83. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@anandtiwary anandtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Pato. Might wanna add a test case later.

@palbizu palbizu merged commit 03f0001 into main Jun 30, 2021
@palbizu palbizu deleted the AddBarGaugeCompactStyle branch June 30, 2021 19:30
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   15m 23s ⏱️ + 1m 37s
937 tests ±0  937 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
943 runs  ±0  943 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 03f0001. ± Comparison against base commit 8206517.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants