Skip to content

feat: adding compact style #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2021
Merged

feat: adding compact style #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b382b6
feat: adding compact style
Jun 30, 2021
4e71396
feat: changing naming from standard to regular
Jun 30, 2021
37fea83
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into AddBa…
Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions projects/observability/src/shared/components/bar-gauge/bar-gauge.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,35 @@
@import 'mixins';

.bar-gauge {
.title {
@include overline($gray-7);
padding-bottom: 24px;
}
.header-data {
&.regular {
.title {
@include overline($gray-7);
padding-bottom: 24px;
}

.count {
@include subtitle-1($gray-9);
padding-bottom: 8px;
.count {
@include subtitle-1($gray-9);
padding-bottom: 8px;

.units {
@include body-small($gray-5);
.units {
@include body-small($gray-5);
}
}
}

&.compact {
display: flex;
flex-direction: row;
justify-content: space-between;

.title {
@include body-2-medium($gray-7);
}

.count {
@include body-2-regular($gray-5);
}
}
}

Expand Down
20 changes: 15 additions & 5 deletions projects/observability/src/shared/components/bar-gauge/bar-gauge.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ import {
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div class="bar-gauge" (htLayoutChange)="this.checkNearMaxValue()">
<div *ngIf="this.title" class="title">{{ this.title | htDisplayTitle }}</div>
<div class="count">
{{ this.totalValue | number }} / {{ this.maxValue | number }}
<span class="units" *ngIf="this.units">{{ this.units }}</span>
<div class="header-data" [ngClass]="this.display">
<div *ngIf="this.title" class="title">{{ this.title | htDisplayTitle }}</div>
<div class="count">
{{ this.totalValue | number }} / {{ this.maxValue | number }}
<span class="units" *ngIf="this.units">{{ this.units }}</span>
</div>
</div>
<div class="bar">
<div #maxValueBar class="max-value-bar" [ngClass]="{ 'over-max-value': this.overMaxValue }">
Expand All @@ -45,7 +47,7 @@ import {
</div>
</div>
</div>
<div class="legend">
<div *ngIf="this.display === '${BarGaugeStyle.Regular}'" class="legend">
<div class="legend-item" *ngFor="let segment of this.barSegments">
<span class="legend-symbol" [style.backgroundColor]="segment.color"></span>
<span class="legend-value" *ngIf="this.barSegments.length > 1">{{ segment.value | number }}</span>
Expand Down Expand Up @@ -79,6 +81,9 @@ export class BarGaugeComponent implements OnChanges, AfterViewInit {
@Input()
public segments?: Segment[] = [];

@Input()
public display: BarGaugeStyle = BarGaugeStyle.Regular;

public barSegments: BarSegment[] = [];
public totalValue: number = 0;
public overMaxValue: boolean = false;
Expand Down Expand Up @@ -148,3 +153,8 @@ export interface Segment {
interface BarSegment extends Segment {
percentage: number;
}

export const enum BarGaugeStyle {
Regular = 'regular',
Compact = 'compact'
}