Skip to content

feat: inherit all sizing for icons set to inherit #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

jake-bassett
Copy link
Contributor

Description

Inherit font size, height, and width.

@jake-bassett jake-bassett requested a review from a team as a code owner July 15, 2021 00:14
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #992 (37c160f) into main (96c9d5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         815      815           
  Lines       16782    16782           
  Branches     2170     2170           
=======================================
  Hits        14278    14278           
  Misses       2473     2473           
  Partials       31       31           
Impacted Files Coverage Δ
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c9d5b...37c160f. Read the comment docs.

anandtiwary
anandtiwary previously approved these changes Jul 15, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit e61e612 into main Jul 15, 2021
@jake-bassett jake-bassett deleted the icon-size-inherit branch July 15, 2021 19:24
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   15m 0s ⏱️ - 1m 24s
942 tests ±0  942 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
948 runs  ±0  948 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e61e612. ± Comparison against base commit 96c9d5b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants