Skip to content

feat: inherit all sizing for icons set to inherit #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021
Merged

feat: inherit all sizing for icons set to inherit #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0cf845
feat: inherit all sizing for icons set to inherit
jake-bassett Jul 15, 2021
b925ebe
feat: added a couple of icons too
jake-bassett Jul 15, 2021
3ccb4db
fix: currentColor
jake-bassett Jul 15, 2021
37c160f
Merge branch 'main' into icon-size-inherit
jake-bassett Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/assets-library/assets/icons/calls.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions projects/assets-library/assets/icons/protocol.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions projects/assets-library/src/icons/icon-library.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const iconsRootPath = 'assets/icons';
{ key: IconType.ArrowUp, url: `${iconsRootPath}/arrow-up.svg` },
{ key: IconType.ArrowUpLeft, url: `${iconsRootPath}/arrow-up-left.svg` },
{ key: IconType.ArrowUpRight, url: `${iconsRootPath}/arrow-up-right.svg` },
{ key: IconType.Calls, url: `${iconsRootPath}/calls.svg` },
{ key: IconType.CheckCircle, url: `${iconsRootPath}/check-circle.svg` },
{ key: IconType.CheckCircleFill, url: `${iconsRootPath}/check-circle-fill.svg` },
{ key: IconType.ChevronDown, url: `${iconsRootPath}/chevron-down.svg` },
Expand Down Expand Up @@ -69,6 +70,7 @@ const iconsRootPath = 'assets/icons';
{ key: IconType.Node, url: `${iconsRootPath}/node.svg` },
{ key: IconType.Note, url: `${iconsRootPath}/note.svg` },
{ key: IconType.OpenInNewTab, url: `${iconsRootPath}/open-in-new-tab.svg` },
{ key: IconType.Protocol, url: `${iconsRootPath}/protocol.svg` },
{ key: IconType.Python, url: `${iconsRootPath}/python.svg` },
{ key: IconType.Search, url: `${iconsRootPath}/search.svg` },
{ key: IconType.SidebarCollapse, url: `${iconsRootPath}/sidebar-collapse.svg` },
Expand Down
2 changes: 2 additions & 0 deletions projects/assets-library/src/icons/icon-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const enum IconType {
ArrowUp = 'svg:arrow-up',
ArrowUpLeft = 'svg:arrow-up-left',
ArrowUpRight = 'svg:arrow-up-right',
Calls = 'svg:calls',
Cancel = 'cancel',
CheckCircle = 'svg:check-circle',
CheckCircleFill = 'svg:check-circle-fill',
Expand Down Expand Up @@ -85,6 +86,7 @@ export const enum IconType {
OpenInNewTab = 'svg:open-in-new-tab',
PageView = 'pageview',
Previous = 'navigate_before',
Protocol = 'svg:protocol',
Python = 'svg:python',
Refresh = 'refresh',
Remove = 'remove',
Expand Down
4 changes: 2 additions & 2 deletions projects/components/src/icon/icon.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
}

&.inherit {
font-size: 32px;
height: 32px;
font-size: inherit;
height: inherit;
width: inherit;
}
}