Skip to content

Custom metric topology modifications anand #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 15, 2021

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary changed the base branch from main to custom-metric-topology July 15, 2021 19:19
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #995 (1dee671) into main (02720e1) will decrease coverage by 36.81%.
The diff coverage is 32.53%.

❗ Current head 1dee671 differs from pull request most recent head 7c477ea. Consider uploading reports for the commit 7c477ea to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #995       +/-   ##
===========================================
- Coverage   85.07%   48.26%   -36.82%     
===========================================
  Files         815      820        +5     
  Lines       16782    16847       +65     
  Branches     2170     2185       +15     
===========================================
- Hits        14278     8131     -6147     
- Misses       2473     8689     +6216     
+ Partials       31       27        -4     
Impacted Files Coverage Δ
...api-node-renderer/api-node-box-renderer.service.ts 33.33% <ø> (-66.67%) ⬇️
...node-renderer/backend-node-box-renderer.service.ts 28.57% <ø> (-57.15%) ⬇️
...node-renderer/service-node-box-renderer.service.ts 33.33% <ø> (-66.67%) ⬇️
.../edge/curved/entity-edge-curve-renderer.service.ts 8.65% <6.25%> (-91.35%) ⬇️
...ology/node/box/entity-node-box-renderer.service.ts 7.27% <7.69%> (-71.64%) ⬇️
...y/topology-data-source-model-properties.service.ts 11.76% <11.76%> (ø)
...ets/topology/topology-widget-renderer.component.ts 39.21% <33.33%> (-58.71%) ⬇️
...ogy/metrics/topology-metric-with-category.model.ts 41.66% <41.66%> (ø)
...ata/graphql/topology/topology-data-source.model.ts 38.23% <50.00%> (-58.44%) ⬇️
...topology/metrics/topology-metric-category.model.ts 76.92% <76.92%> (ø)
... and 287 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02720e1...7c477ea. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…om:hypertrace/hypertrace-ui into custom-metric-topology-modifications-anand
@anandtiwary anandtiwary changed the base branch from custom-metric-topology to main July 15, 2021 22:06
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary changed the base branch from main to custom-metric-topology July 15, 2021 22:19
@anandtiwary anandtiwary changed the base branch from custom-metric-topology to main July 15, 2021 22:19
@github-actions
Copy link

Unit Test Results

0 files   -     4  0 suites   - 259   0s ⏱️ - 15m 24s
0 tests  - 942  0 ✔️  - 942  0 💤 ±0  0 ❌ ±0 
0 runs   - 948  0 ✔️  - 948  0 💤 ±0  0 ❌ ±0 

Results for commit 7c477ea. ± Comparison against base commit 02720e1.

@anandtiwary anandtiwary deleted the custom-metric-topology-modifications-anand branch July 16, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants