Skip to content

feat: adding topology custom metric model and service #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 15, 2021

Description

Please include a summary of the change, motivation and context.
feat: adding topology custom metric model and service

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner July 15, 2021 22:29
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #999 (039f13c) into main (7d48c89) will decrease coverage by 0.04%.
The diff coverage is 70.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   85.07%   85.03%   -0.05%     
==========================================
  Files         815      821       +6     
  Lines       16782    16837      +55     
  Branches     2170     2180      +10     
==========================================
+ Hits        14278    14317      +39     
- Misses       2473     2489      +16     
  Partials       31       31              
Impacted Files Coverage Δ
...graphql/topology/metrics/topology-metrics.model.ts 0.00% <0.00%> (ø)
...rd/widgets/topology/metric/edge-metric-category.ts 0.00% <0.00%> (ø)
...rd/widgets/topology/metric/node-metric-category.ts 0.00% <0.00%> (ø)
...y/topology-data-source-model-properties.service.ts 68.42% <68.42%> (ø)
...topology/metrics/topology-metric-category.model.ts 100.00% <100.00%> (ø)
...ogy/metrics/topology-metric-with-category.model.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d48c89...039f13c. Read the comment docs.

@anandtiwary
Copy link
Contributor Author

anandtiwary commented Jul 15, 2021

For Full Change please refer . #995 . This PR has few commits on top of #965 . Please change the base branch to 965 if you only want to see the new diff

#999 and #1000 contains complete change of #995 in two parts.

@itssharmasandeep @aaron-steinfeld

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 47a0ae0 into main Jul 16, 2021
@anandtiwary anandtiwary deleted the topology-custom-metric-1 branch July 16, 2021 17:06
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  +3   15m 17s ⏱️ -14s
944 tests +2  944 ✔️ +2  0 💤 ±0  0 ❌ ±0 
951 runs  +3  951 ✔️ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 47a0ae0. ± Comparison against base commit 7d48c89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants