Skip to content

[spike] Adds bundle helper submission call #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Dec 12, 2024

This PR is closed.

[spike] adds bundle helper submission call

TL;DR

This PR modifies the submit task in the Builder to call the bundle helper contract's submit function.

What changed?

  • Introduced FillPermit2 vector for transaction fills
  • Replaced Zenith::BlockHeader with BlockHeader type
  • Added submitCall structure with fills, header, and signature components
  • Modified transaction building to use the bundle helper submit function
  • Added error handling for transaction submission

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott added the enhancement New feature or request label Dec 12, 2024 — with Graphite App
@dylanlott dylanlott changed the title feat: adds bundle helper submission call (WIP) feat: adds bundle helper submission call Dec 16, 2024
@dylanlott dylanlott changed the title (WIP) feat: adds bundle helper submission call [WIP] feat: adds bundle helper submission call Dec 16, 2024
@dylanlott dylanlott force-pushed the 12-12-feat_adds_bundle_helper_submission_call branch from da4b819 to 3ec2a49 Compare December 16, 2024 19:13
@dylanlott dylanlott changed the title [WIP] feat: adds bundle helper submission call [WIP] feat: Adds bundle helper submission call Dec 17, 2024
@dylanlott dylanlott force-pushed the 12-12-feat_adds_bundle_helper_submission_call branch from 3ec2a49 to bdeb394 Compare December 20, 2024 19:50
@dylanlott dylanlott force-pushed the 12-12-feat_adds_bundle_helper_submission_call branch 2 times, most recently from d1c25a7 to e2f044b Compare January 3, 2025 23:58
@dylanlott dylanlott force-pushed the 12-12-feat_adds_bundle_helper_submission_call branch from e2f044b to 0c2a5d0 Compare January 8, 2025 05:16
@dylanlott dylanlott changed the title [WIP] feat: Adds bundle helper submission call [spike] Adds bundle helper submission call Jan 10, 2025
@dylanlott dylanlott closed this Jan 10, 2025
dylanlott added a commit that referenced this pull request Jan 22, 2025
# tl;dr 

This PR adds bundle ingestion from the tx-pool to the Signet Builder.

## Changes 

- `InProgressBlock` building process now checks the cache for bundles
- Ingests any new bundles that it finds into the in progress block
- Changes the block submission call to use the BuilderHelper contract
- Stubs out bundle simulation (see [ENG-640](https://linear.app/initiates/issue/ENG-640/add-simulation-engine-to-the-example-builder))

## Configuration updates

This PR requires an environment variable (the builder helper contract address) be added to the configuration, and thus must go in after the config is added to the environment in [the-infra PR #308](init4tech/the-infra#308)

Closes [ENG-549](https://linear.app/initiates/issue/ENG-629/add-bundle-with-signed-orders-support-by-using-the-helper-contract-to)
Supersedes builder [PR #34](#34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant