Skip to content

feat: adds bundles to in progress block creation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 22, 2025

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Jan 10, 2025

tl;dr

This PR adds bundle ingestion from the tx-pool to the Signet Builder.

Changes

  • InProgressBlock building process now checks the cache for bundles
  • Ingests any new bundles that it finds into the in progress block
  • Changes the block submission call to use the BuilderHelper contract
  • Stubs out bundle simulation (see ENG-640)

Configuration updates

This PR requires an environment variable (the builder helper contract address) be added to the configuration, and thus must go in after the config is added to the environment in the-infra PR #308

Closes ENG-549
Supersedes builder PR #34

Copy link
Contributor Author

dylanlott commented Jan 10, 2025

@dylanlott dylanlott changed the title feat: adds bundles to in progress block creation [wip] feat: adds bundles to in progress block creation Jan 10, 2025
@dylanlott dylanlott marked this pull request as ready for review January 10, 2025 19:14
@dylanlott dylanlott force-pushed the dylan/async-http-client branch from 943e6c4 to 70eb141 Compare January 10, 2025 19:49
@dylanlott dylanlott force-pushed the dylan/bundle-submission branch from e272a8f to 0d11e60 Compare January 10, 2025 19:49
@dylanlott dylanlott force-pushed the dylan/async-http-client branch from 70eb141 to dbd451d Compare January 10, 2025 19:52
@dylanlott dylanlott force-pushed the dylan/bundle-submission branch from 0d11e60 to c826b10 Compare January 10, 2025 19:52
@dylanlott dylanlott force-pushed the dylan/async-http-client branch 2 times, most recently from cab238a to 2c9f717 Compare January 10, 2025 20:08
@dylanlott dylanlott force-pushed the dylan/bundle-submission branch from c826b10 to c4f971c Compare January 10, 2025 20:08
@dylanlott dylanlott changed the base branch from dylan/async-http-client to graphite-base/45 January 10, 2025 20:10
@dylanlott dylanlott force-pushed the dylan/bundle-submission branch from c4f971c to 45a360e Compare January 10, 2025 20:10
@dylanlott dylanlott changed the base branch from graphite-base/45 to main January 10, 2025 20:11
@dylanlott dylanlott force-pushed the dylan/bundle-submission branch 2 times, most recently from dd08656 to 057ae57 Compare January 10, 2025 23:18
@dylanlott dylanlott changed the title [wip] feat: adds bundles to in progress block creation feat: adds bundles to in progress block creation Jan 10, 2025
@dylanlott dylanlott added the enhancement New feature or request label Jan 11, 2025 — with Graphite App
@dylanlott dylanlott self-assigned this Jan 11, 2025
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks great

@anna-carroll
Copy link
Contributor

anna-carroll commented Jan 17, 2025

  • Simulates those blocks, disallowing 4844 transactions and respecting the reverted transaction list
  • Passes a host_provider instance to the BlockBuilder in order to facilitate call simulation

would update these PR comments @dylanlott

@dylanlott dylanlott force-pushed the dylan/bundle-submission branch from 8a8b302 to 99cd16f Compare January 17, 2025 18:04
Copy link
Contributor

@anna-carroll anna-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the simulation for individual transactions could be at odds with un-simulated bundle logic...

@dylanlott dylanlott merged commit e0f0245 into main Jan 22, 2025
5 checks passed
@dylanlott dylanlott deleted the dylan/bundle-submission branch January 22, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants