Fixed coverity issues in src/acl_kernel_if.cpp #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxian2
force-pushed
the
coverity-acl-kernel-if
branch
2 times, most recently
from
0c2f83e to
665e419
Compare
haoxian2
force-pushed
the
coverity-acl-kernel-if
branch
3 times, most recently
from
f6957ff to
289cbd8
Compare
pcolberg
reviewed
Dec 8, 2022
haoxian2
force-pushed
the
coverity-acl-kernel-if
branch
from
289cbd8 to
d1922e2
Compare
…ment to printf format specifier (PRINTF_ARGS) 1. Used std::optional::value() and some pointer dereferencing to obtain the value of the argument to printf. 2. Used %zu instead of %d to print out unsigned long types (size_t mostly)
haoxian2
force-pushed
the
coverity-acl-kernel-if
branch
from
d1922e2 to
64ada5c
Compare
pcolberg
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coverity issue in acl_kernel_if.cpp: Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)
std::optional::value()and some pointer dereferencing to obtain the value of the argument toprintf.%zuinstead of%dto print outunsigned longtypes (size_tmostly)Coverity issue in acl_kernel_if.cpp: Type: Reliance on integer endianness (INCOMPATIBLE_CAST)
Discussed in #226 instead.