Upgrade to c++17 standard #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
suggested changes
Feb 7, 2022
There was a problem hiding this comment.
Thanks @sherry-yuan!
Could you extend the commit message with a quick summary of compiler support? You can use the C++17 core and library feature tables in https://en.cppreference.com/w/cpp/compiler_support to figure out the minimum required compiler versions for GCC and MSVC. Ubuntu 18.04 has GCC 7.5 and for Windows we support MSVC 2017.
-------------------------------- C++17 contains much more features that: 1. add flexibility (eg. std::any, std::variant) 2. potential performance improvement 3. type safety For more info see: https://en.cppreference.com/w/cpp/17 Compiler support (min version required to access all C++17 features): 1. GCC ^7 2. MSVC ^19.14 Our current version: 1. GCC 7.5 2. MSVC 2017 = MSVC 19.16 To figure out local MSVC compiler version run: `cl /Bv` For more information about what feature is supported at which version see: https://en.cppreference.com/w/cpp/compiler_support
Thanks for the suggestion! I checked the compiler versions and we satisfied all the requirements (for MSVC, the minimum required to access all feature is 19.14, and we are at 19.16, phew, that was close!) I put how to check MSVC compiler version in commit msg too. |
pcolberg
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c++17 supports many more features that allows greater flexibilities, and potential performance optimization.
https://en.cppreference.com/w/cpp/17