Increase coverage

.github/workflows/static-analysis-pr.yml

@@ -75,7 +75,7 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
-      - name: Search for linter suppression markers
+      - name: Search for forbidden patterns in student tasks
         run: |
           export BASE_REF=${{ github.event.pull_request.base.ref }}
           export CHANGED_FILES="$(git diff --name-only origin/$BASE_REF HEAD | grep '^tasks/')"
@@ -92,5 +92,10 @@ jobs:
               echo "::error::Found 'IWYU pragma' in $file."
               exit 1
             fi
+            if grep -n "ExpectIncompleteLifecycle" "$file"; then
+              echo "::error::Found 'ExpectIncompleteLifecycle' in $file." \
+                   "This function is for internal testing only and should not be used in student tasks."
+              exit 1
+            fi
           done
-          echo "No linter suppression markers found in changed files."
+          echo "No forbidden patterns found in changed files."

.github/workflows/ubuntu.yml

@@ -331,10 +331,10 @@ jobs:
         env:
           PPC_NUM_PROC: 1
           PPC_ASAN_RUN: 1
-  gcc-build-codecov:
-    needs:
-      - gcc-test-extended
-      - clang-test-extended
+  clang-build-codecov:
+    # needs:
+    #   - gcc-test-extended
+    #   - clang-test-extended
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
@@ -343,58 +343,66 @@ jobs:
       - name: Setup environment
         run: |
           sudo apt-get update
-          sudo apt-get install --no-install-recommends -y \
-            gcc-14 g++-14 ninja-build libmpich-dev libomp-dev valgrind gcovr
+          sudo apt-get install --no-install-recommends -y ninja-build libmpich-dev libomp-dev valgrind python3-pip
+          wget https://apt.llvm.org/llvm.sh
+          chmod u+x llvm.sh
+          sudo ./llvm.sh 20 all
+          python3 -m pip install -r requirements.txt
       - name: ccache
         uses: hendrikmuhs/[email protected]
         with:
-          key: ${{ runner.os }}-gcc
+          key: ${{ runner.os }}-clang-coverage
           create-symlink: true
           max-size: 1G
       - name: CMake configure
         run: >
           cmake -S . -B build -G Ninja
           -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccache
           -D CMAKE_BUILD_TYPE=RELEASE
-          -D CMAKE_VERBOSE_MAKEFILE=ON -D USE_COVERAGE=ON
+          -D CMAKE_VERBOSE_MAKEFILE=ON -D USE_LLVM_COVERAGE=ON
+        env:
+          CC: clang-20
+          CXX: clang++-20
       - name: Build project
         run: |
           cmake --build build --parallel
+        env:
+          CC: clang-20
+          CXX: clang++-20
       - name: Run tests (MPI)
-        run: scripts/run_tests.py --running-type="processes"
+        run: scripts/run_tests.py --running-type="processes_coverage" --counts 2
         env:
-          PPC_NUM_PROC: 2
           PPC_NUM_THREADS: 2
+          LLVM_PROFILE_FILE: "build/llvm_profile_%p_%m.profraw"
+          PPC_DISABLE_VALGRIND: 1
       - name: Run tests (threads)
         run: scripts/run_tests.py --running-type="threads" --counts 1 2 3 4
         env:
           PPC_NUM_PROC: 1
-      - name: Generate gcovr Coverage Data
+          LLVM_PROFILE_FILE: "build/llvm_profile_%p_%m.profraw"
+          PPC_DISABLE_VALGRIND: 1
+      - name: Generate LLVM Coverage Data
         run: |
-          mkdir cov-report
-          cd build
-          gcovr -r ../ \
-                --exclude '.*3rdparty/.*' \
-                --exclude '/usr/.*' \
-                --exclude '.*tasks/.*/tests/.*' \
-                --exclude '.*modules/.*/tests/.*' \
-                --exclude '.*tasks/common/runners/.*' \
-                --exclude '.*modules/runners/.*' \
-                --exclude '.*modules/util/include/perf_test_util.hpp' \
-                --exclude '.*modules/util/include/func_test_util.hpp' \
-                --exclude '.*modules/util/src/func_test_util.cpp' \
-                --xml --output ../coverage.xml \
-                --html=../cov-report/index.html --html-details
+          scripts/generate_llvm_coverage.py \
+            --build-dir build \
+            --output-dir cov-report \
+            --llvm-profdata llvm-profdata-20 \
+            --llvm-cov llvm-cov-20
+          # Check if files were generated
+          ls -la build/coverage.lcov
+          ls -la build/cov-report/
       - name: Upload coverage reports to Codecov
         uses: codecov/[email protected]
         with:
-          files: coverage.xml
+          files: ./build/coverage.lcov
+          verbose: true
+          name: llvm-codecov
       - name: Upload coverage report artifact
         id: upload-cov
         uses: actions/upload-artifact@v4
         with:
           name: cov-report
-          path: 'cov-report'
+          path: 'build/cov-report'
       - name: Comment coverage report link
         # TODO: Support PRs from forks and handle cases with insufficient write permissions
         continue-on-error: true

CMakeLists.txt

@@ -20,7 +20,7 @@ include(cmake/sphinx.cmake)
 add_subdirectory(docs)
 
 if( USE_SCOREBOARD OR USE_DOCS )
-    return()
+  return()
 endif()
 
 ############################ Configures #############################

cmake/configure.cmake

@@ -28,7 +28,7 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
 
-if(USE_COVERAGE)
+if(USE_COVERAGE OR USE_LLVM_COVERAGE)
   set(CMAKE_INSTALL_RPATH "${CMAKE_BINARY_DIR}/ppc_onetbb/install/lib")
 else()
   set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib")
@@ -75,6 +75,12 @@ if(UNIX)
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --coverage")
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage")
   endif(USE_COVERAGE)
+  if(USE_LLVM_COVERAGE)
+    set(CMAKE_C_FLAGS
+        "${CMAKE_C_FLAGS} -fprofile-instr-generate -fcoverage-mapping")
+    set(CMAKE_CXX_FLAGS
+        "${CMAKE_CXX_FLAGS} -fprofile-instr-generate -fcoverage-mapping")
+  endif(USE_LLVM_COVERAGE)
 endif()
 
 if(MSVC)

cmake/gtest.cmake

@@ -25,6 +25,7 @@ ExternalProject_Add(
     "${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/build" --prefix
     "${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/install")
 
+# Link Google Test library to target
 function(ppc_link_gtest exec_func_lib)
   # Add external project include directories
   target_include_directories(

cmake/onetbb.cmake

@@ -1,12 +1,12 @@
 include(ExternalProject)
 
 if(WIN32)
-  set(ppc_onetbb_TEST_COMMAND
+  set(PPC_ONETBB_TEST_COMMAND
       "${CMAKE_COMMAND}" -E copy_directory
       "${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/install/bin"
       "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")
 else()
-  set(ppc_onetbb_TEST_COMMAND "")
+  set(PPC_ONETBB_TEST_COMMAND "")
 endif()
 
 ExternalProject_Add(
@@ -31,7 +31,7 @@ ExternalProject_Add(
   INSTALL_COMMAND
     "${CMAKE_COMMAND}" --install "${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/build"
     --prefix "${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/install"
-  TEST_COMMAND ${ppc_onetbb_TEST_COMMAND})
+  TEST_COMMAND ${PPC_ONETBB_TEST_COMMAND})
 
 install(DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/install/"
         DESTINATION "${CMAKE_INSTALL_PREFIX}")
@@ -43,6 +43,7 @@ else()
   set(PPC_TBB_LIB_NAME tbb)
 endif()
 
+# Link TBB library to target
 function(ppc_link_tbb exec_func_lib)
   # Add external project include directories
   target_include_directories(${exec_func_lib}

cmake/stb.cmake

@@ -1,3 +1,4 @@
+# Link STB image library to target
 function(ppc_link_stb exec_func_lib)
   add_library(stb_image STATIC
               ${CMAKE_SOURCE_DIR}/3rdparty/stb_image_wrapper.cpp)

modules/CMakeLists.txt

@@ -1,6 +1,6 @@
 message(STATUS "Core components")
-set(exec_func_tests "core_func_tests")
-set(exec_func_lib "core_module_lib")
+set(EXEC_FUNC_TESTS "core_func_tests")
+set(EXEC_FUNC_LIB "core_module_lib")
 
 subdirlist(subdirs ${CMAKE_CURRENT_SOURCE_DIR})
 
@@ -18,36 +18,36 @@ foreach(subd ${subdirs})
   list(APPEND FUNC_TESTS_SOURCE_FILES ${TMP_FUNC_TESTS_SOURCE_FILES})
 endforeach()
 
-project(${exec_func_lib})
-add_library(${exec_func_lib} STATIC ${LIB_SOURCE_FILES})
-set_target_properties(${exec_func_lib} PROPERTIES LINKER_LANGUAGE CXX)
+project(${EXEC_FUNC_LIB})
+add_library(${EXEC_FUNC_LIB} STATIC ${LIB_SOURCE_FILES})
+set_target_properties(${EXEC_FUNC_LIB} PROPERTIES LINKER_LANGUAGE CXX)
 
 # Add include directories to target
 target_include_directories(
-  ${exec_func_lib} PUBLIC ${CMAKE_SOURCE_DIR}/3rdparty
+  ${EXEC_FUNC_LIB} PUBLIC ${CMAKE_SOURCE_DIR}/3rdparty
                           ${CMAKE_SOURCE_DIR}/modules ${CMAKE_SOURCE_DIR}/tasks)
 
-ppc_link_envpp(${exec_func_lib})
-ppc_link_json(${exec_func_lib})
-ppc_link_gtest(${exec_func_lib})
-ppc_link_threads(${exec_func_lib})
-ppc_link_openmp(${exec_func_lib})
-ppc_link_tbb(${exec_func_lib})
-ppc_link_mpi(${exec_func_lib})
-ppc_link_stb(${exec_func_lib})
+ppc_link_envpp(${EXEC_FUNC_LIB})
+ppc_link_json(${EXEC_FUNC_LIB})
+ppc_link_gtest(${EXEC_FUNC_LIB})
+ppc_link_threads(${EXEC_FUNC_LIB})
+ppc_link_openmp(${EXEC_FUNC_LIB})
+ppc_link_tbb(${EXEC_FUNC_LIB})
+ppc_link_mpi(${EXEC_FUNC_LIB})
+ppc_link_stb(${EXEC_FUNC_LIB})
 
-add_executable(${exec_func_tests} ${FUNC_TESTS_SOURCE_FILES})
+add_executable(${EXEC_FUNC_TESTS} ${FUNC_TESTS_SOURCE_FILES})
 
-target_link_libraries(${exec_func_tests} PUBLIC ${exec_func_lib})
+target_link_libraries(${EXEC_FUNC_TESTS} PUBLIC ${EXEC_FUNC_LIB})
 
 enable_testing()
-add_test(NAME ${exec_func_tests} COMMAND ${exec_func_tests})
+add_test(NAME ${EXEC_FUNC_TESTS} COMMAND ${EXEC_FUNC_TESTS})
 
 # Installation rules
 install(
-  TARGETS ${exec_func_lib}
+  TARGETS ${EXEC_FUNC_LIB}
   ARCHIVE DESTINATION lib
   LIBRARY DESTINATION lib
   RUNTIME DESTINATION bin)
 
-install(TARGETS ${exec_func_tests} RUNTIME DESTINATION bin)
+install(TARGETS ${EXEC_FUNC_TESTS} RUNTIME DESTINATION bin)