LSPS5: clarify per-method cooldown to minutes #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts rate limiting guidance to be on the order of minutes. Rationale is that devices can miss one wake and be available shortly after, so several notifications per hour should be acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received feedback on the LSPS5 reference implementation (see lightningdevkit/rust-lightning#3975 (comment)) that an hour-scale cooldown is too high. If two payments arrive an hour apart, missing the first wakeup should not block sending another, since phones can be offline, low battery, or briefly unable to wake. Several notifications per hour should be acceptable.
Also a few typos are fixed