Skip to content

[LSPS5] Change notification cooldown time to 1 minute, also update docs #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

[LSPS5] Change notification cooldown time to 1 minute, also update docs #3994

merged 1 commit into from
Aug 13, 2025

Conversation

martinsaposnic
Copy link
Contributor

@martinsaposnic martinsaposnic commented Aug 7, 2025 •
edited
Loading

LSPS5 follow ups. Addressing comments #3975 (review) and #3975 (comment)

changes:

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 7, 2025 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnic martinsaposnic mentioned this pull request Aug 7, 2025
Open
18 tasks
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.91%. Comparing base (6d47f0a) to head (c7694f4).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3994      +/-   ##
==========================================
+ Coverage   88.74%   88.91%   +0.17%     
==========================================
  Files         173      174       +1     
  Lines      124899   125114     +215     
  Branches   124899   125114     +215     
==========================================
+ Hits       110841   111249     +408     
+ Misses      11631    11354     -277     
- Partials     2427     2511      +84
Flag Coverage Δ
fuzzing 22.12% <0.00%> (?)
tests 88.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tnull
tnull reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase now.

@tnull tnull removed the request for review from joostjager August 7, 2025 17:30
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from ecf258c to 43eeb48 Compare August 7, 2025 17:37
@martinsaposnic
Copy link
Contributor Author

rebase done!

@martinsaposnic martinsaposnic requested a review from tnull August 7, 2025 17:39
graphite-app[bot]
graphite-app bot reviewed Aug 7, 2025
View reviewed changes
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from 43eeb48 to 24712cf Compare August 7, 2025 17:42
tnull
tnull reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned elsewhere, we might need a spec change in parallel to this.

Also, nit: 'LSP5', 'dooldown' and 'alsp' typos in the commit message (which could otherwise also use a bit more detail what this change is and why we want it).

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@martinsaposnic martinsaposnic changed the title [LSP5] Change notification dooldown time to 1 minute, alsp update docs [LSP5] Change notification cooldown time to 1 minute, also update docs Aug 11, 2025
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from 24712cf to d638113 Compare August 11, 2025 15:15
@martinsaposnic martinsaposnic changed the title [LSP5] Change notification cooldown time to 1 minute, also update docs [LSPS5] Change notification dooldown time to 1 minute, alsp update docs Aug 11, 2025
@martinsaposnic
Copy link
Contributor Author

martinsaposnic commented Aug 11, 2025 •
edited
Loading

we might need a spec change in parallel to this

lightning/blips#64 spec update PR

@martinsaposnic martinsaposnic requested a review from tnull August 11, 2025 16:33
tnull
tnull reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good to me, but please fixup the typos in the commit message, as mentioned above.

lightning-liquidity/src/lsps5/service.rs Outdated
@@ -429,7 +429,7 @@ where
.last_notification_sent
.get(&notification.method)
.map(|last_sent| now.duration_since(&last_sent))
.map_or(false, |duration| duration < DEFAULT_NOTIFICATION_COOLDOWN_HOURS)
.map_or(false, |duration: Duration| duration < NOTIFICATION_COOLDOWN_TIME)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this : Duration suddenly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI force-pushed this small change without a fixup https://github.com/lightningdevkit/rust-lightning/compare/d638113b68b2de0ec02dd5d2a7574f7854d5005c..8b326536eed3eaff61d4c261dd5f83d96620f76b

@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from d638113 to 8b32653 Compare August 12, 2025 12:55
@martinsaposnic martinsaposnic force-pushed the lsps5-cooldown-time-fix branch from 8b32653 to c7694f4 Compare August 12, 2025 13:46
@martinsaposnic martinsaposnic changed the title [LSPS5] Change notification dooldown time to 1 minute, alsp update docs [LSPS5] Change notification cooldown time to 1 minute, also update docs Aug 12, 2025
@martinsaposnic martinsaposnic requested a review from tnull August 12, 2025 18:28
@martinsaposnic
Copy link
Contributor Author

also fixed the commit message. sorry about the typos!

tnull
tnull approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Simple enough, so landing this.

(the commit message could have still used some motiviation, etc ;P)

@tnull tnull merged commit efb8d58 into lightningdevkit:main Aug 13, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinsaposnic @ldk-reviews-bot @tnull