Beta to master #18395
Merged
Beta to master #18395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of the issue: If a device doesn't trust NV Access's TLS certificate, fetches to the add-on store fails. When performing an update check, we update windows root certificates if our certificate is invalid or out of date. Description of user facing changes: Users without a trusted NV Access TLS certificate installed already should be able to access the add-on store Description of developer facing changes: Code related to updating root certificates is deprecated as it is not intended for the public Description of development approach: Made the code to update certificates more generic
There was a problem hiding this comment.
Pull Request Overview
This PR refactors update checking to use a centralized networking utility that handles Windows root certificate updates, introduces deprecation warnings for legacy constants, updates related documentation, and adjusts some driver and data manager calls to the new helper.
- Add a
utils/networking.pymodule with Windows cert-update helpers - Replace in-module update–fetch logic in
updateCheck.pyandaddonStore/dataManager.pywith_fetchUrlAndUpdateRootCertificates - Document deprecated
CERT_USAGE_MATCH,CERT_CHAIN_PARA, andUPDATE_FETCH_TIMEOUT_Sand update detection in a braille driver
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/changes.md | Add a “Deprecations” section for three soon-to-be-removed constants |
| source/utils/networking.py | New helper for fetching URLs with Windows root cert updates |
| source/updateCheck.py | Switch to _fetchUrlAndUpdateRootCertificates and clean up old cert logic |
| source/brailleDisplayDrivers/nlseReaderZoomax.py | Update addUsbDevices call to use ProtocolType.SERIAL |
| source/addonStore/dataManager.py | Use the new networking helper in _getCacheHash |
source/updateCheck.py
Outdated
|
|
||
| data = res.read().decode("utf-8") # Ensure the response is decoded correctly | ||
| data = result.content.decode("utf-8") # Ensure the response is decoded correctly |
There was a problem hiding this comment.
[nitpick] Using result.content.decode("utf-8") may ignore the server-declared encoding. Consider using result.text which respects response.encoding.
Suggested change
| data = result.content.decode("utf-8") # Ensure the response is decoded correctly | |
| data = result.text # Automatically decode using the server-declared encoding |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.