-
Notifications
You must be signed in to change notification settings - Fork 65
Closed
Labels
Description
What happened?
We can clearly see that, in each version starting from 9.0.0-beta.1, the VERSION
constant in dist-bundle/index.js
has always been set to the placeholder value 0.0.0-development
, which is supposed to be replaced by semantic-release-plugin-update-version-in-files
with the actual version number.
As a result, the default User-Agent
does not have the correct version number for octokit-request.js
either.
> require("@octokit/request").request.endpoint.DEFAULTS;
{
method: 'GET',
baseUrl: 'https://api.github.com',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-request.js/0.0.0-development Node.js/20.19.2 (darwin; arm64)'
},
mediaType: { format: '' }
}
It was introduced in #678
Expected
var VERSION = "10.0.2";
Actual
var VERSION = "0.0.0-development";
Versions
@octokit/request@>=9.0.0-beta.1
Relevant log output
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
✅ Done