Skip to content

fix(pkg): unreplaced version number in dist-bundle/ #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

wxh06
Copy link
Contributor

@wxh06 wxh06 commented Jun 20, 2025

Resolves #764

Please note that since I don't have write access to this package on npm registry, npx semantic-release --dry-run refused to continue processing. So the fix is NOT fully tested.


Before the change?

  • Got var VERSION = "0.0.0-development"; in dist-bundle/index.js

After the change?

  • 0.0.0-development should be replaced with the actual version number

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@octokit
Copy link

octokit bot commented Jun 20, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 enabled auto-merge (squash) June 20, 2025 02:21
@wolfy1339 wolfy1339 merged commit 5b181af into octokit:main Jun 20, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Jun 20, 2025
Copy link

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wxh06
Copy link
Contributor Author

wxh06 commented Jun 20, 2025

Can confirm the fix did work!

Screenshot 2025-06-20 at 03.24.43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[BUG]: VERSION placeholder is not replaced in bundled dist
2 participants