-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[chore][pkg/fileconsumer] - Move archive into separate package #39353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][pkg/fileconsumer] - Move archive into separate package #39353
Conversation
fc31fc0
to
7c4a971
Compare
7c4a971
to
391371d
Compare
d45b3d4
to
d190a7f
Compare
6987a29
to
2c1d990
Compare
2c1d990
to
937e278
Compare
@djaglowski can you take a look here? I've added tests and addressed the comments. |
c63da6b
to
ab5f217
Compare
9ced4b0
to
47e3c91
Compare
47e3c91
to
c2f18b7
Compare
acfb275
to
94f1c4d
Compare
@djaglowski The testing should be good now. |
f8aea3a
to
eeafee1
Compare
If I'm not mistaken, when you say I've taken this into consideration and reworked the approach. We now simulate a poll cycle and expect fingerprints to match. Please take a look when you can. |
eeafee1
to
70d561d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating. It's so simple even I can understand it now.
@andrzej-stencel PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some nits about logging. It's good to merge from my perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…telemetry#39353) #### Description Move archive into a separate package to make code more testable and less complicated overall. This also changes function `instantiateTracker` to `instantiateTrackerAndArchive` a little bit to initialize the archive and pass it to the tracker for writing older offsets. This PR also drops some of the edge cases to reduce the complexity. I'll work on them later <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates open-telemetry#38056
Description
Move archive into a separate package to make code more testable and less complicated overall.
This also changes function
instantiateTracker
toinstantiateTrackerAndArchive
a little bit to initialize the archive and pass it to the tracker for writing older offsets.This PR also drops some of the edge cases to reduce the complexity. I'll work on them later
Link to tracking issue
Relates #38056