-
Notifications
You must be signed in to change notification settings - Fork 165
8253939: [TESTBUG] Increase coverage of the cgroups detection code #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
3640d59
to
72765b5
Compare
@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
@jmtd this pull request can not be integrated into git checkout 8253939-jdk8u-dev
git fetch https://git.openjdk.org/jdk8u-dev pr/159
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/159"
git push |
0b56b96
to
e4e9311
Compare
e4e9311
to
2f5230d
Compare
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8253939-jdk8u-dev
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
Backport-of: 42fc15899115ca61151bbee96b5580d4e4252beb
72765b5
to
bed968b
Compare
@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@jmtd This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've approved the bug. Feel free to integrate. Please rebase #185 after. Thanks!
Tier 1 GHA test failure on x86 of |
/integrate |
Going to push as commit 4dfc742. |
This is a backport of 8253939 to jdk8u-dev for cgroups v2 support.
It's not clean: several
Files.writeString
→Files.write(…,.getBytes())
changes needed.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/169/head:pull/169
$ git checkout pull/169
Update a local copy of the PR:
$ git checkout pull/169
$ git pull https://git.openjdk.org/jdk8u-dev pull/169/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 169
View PR using the GUI difftool:
$ git pr show -t 169
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/169.diff