8270517: Add Zero support for LoongArch #413
Conversation
|
👋 Welcome back lzhai! A progress list of the required criteria for merging this PR into |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
bot
added
backport
Webrevs
|
|
As the author of 8270517, the backport looks good to me. The releaes and fastdebug native builds are passed on my loongarch64 platform. I am not a Reviewer. The GHA test failure seems unrelated, see #169 (comment) and #228 (comment). |
openjdk
bot
added
the
approval
|
@xiangzhai This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Hi @theRealAph Could you sponsor it? Thanks, |
|
Hi @jerboaa Could you review and sponsor it please? Thanks, |
I think you should get a review (by a Reviewer of jdk8u) and the maintainer's approval first. |
|
To move this forward, you need to formally request maintainer approval. See https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval I'm assuming from the thumbs up that it does allow Zero builds on LoongArch :) |
|
/approval request allow Zero build on LoongArch |
|
@xiangzhai |
|
/approve yes |
|
@gnu-andrew |
|
@xiangzhai This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
openjdk
bot
added
ready
|
/integrate |
|
@xiangzhai |
|
/sponsor |
|
Going to push as commit 9aabf22.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@gnu-andrew @xiangzhai Pushed as commit 9aabf22. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
It is strange but after integration of this patch, execution of "autogen.sh" using autoconf 2.69 will cut part of the change(tested on macOS+brew). [autoconf (GNU Autoconf) 2.69] diff --git a/common/autoconf/generated-configure.sh b/common/autoconf/generated-configure.sh
index 85eb8a16a21..0803a8782af 100644
--- a/common/autoconf/generated-configure.sh
+++ b/common/autoconf/generated-configure.sh
@@ -1017,7 +1017,6 @@ infodir
docdir
oldincludedir
includedir
-runstatedir
localstatedir
sharedstatedir
sysconfdir
@@ -1263,7 +1262,6 @@ datadir='${datarootdir}'
sysconfdir='${prefix}/etc'
sharedstatedir='${prefix}/com'
localstatedir='${prefix}/var'
-runstatedir='${localstatedir}/run'
includedir='${prefix}/include'
oldincludedir='/usr/include'
docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
@@ -1516,15 +1514,6 @@ do
| -silent | --silent | --silen | --sile | --sil)
silent=yes ;;
- -runstatedir | --runstatedir | --runstatedi | --runstated \
- | --runstate | --runstat | --runsta | --runst | --runs \
- | --run | --ru | --r)
- ac_prev=runstatedir ;;
- -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \
- | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \
- | --run=* | --ru=* | --r=*)
- runstatedir=$ac_optarg ;;
-
-sbindir | --sbindir | --sbindi | --sbind | --sbin | --sbi | --sb)
ac_prev=sbindir ;;
-sbindir=* | --sbindir=* | --sbindi=* | --sbind=* | --sbin=* \
@@ -1662,7 +1651,7 @@ fi
for ac_var in exec_prefix prefix bindir sbindir libexecdir datarootdir \
datadir sysconfdir sharedstatedir localstatedir includedir \
oldincludedir docdir infodir htmldir dvidir pdfdir psdir \
- libdir localedir mandir runstatedir
+ libdir localedir mandir
do
eval ac_val=\$$ac_var
# Remove trailing slashes.
@@ -1815,7 +1804,6 @@ Fine tuning of the installation directories:
--sysconfdir=DIR read-only single-machine data [PREFIX/etc]
--sharedstatedir=DIR modifiable architecture-independent data [PREFIX/com]
--localstatedir=DIR modifiable single-machine data [PREFIX/var]
- --runstatedir=DIR modifiable per-process data [LOCALSTATEDIR/run]
--libdir=DIR object code libraries [EPREFIX/lib]
--includedir=DIR C header files [PREFIX/include]
--oldincludedir=DIR C header files for non-gcc [/usr/include]
@@ -4440,7 +4428,7 @@ VS_TOOLSET_SUPPORTED_2022=true |
|
the same result is on Linux, the next run of "autogen.sh" will delete part of this change. |
|
Hi @mrserb Due to AC_INIT: add --runstatedir option to configure. And I also tested with autoconf 2.69 and 2.72, there is Thanks, |
Yes, we've gone back and forth on this before. Some distros have this locally patched in, others don't, and it really depends where I'm thinking of just backporting JDK-8195689 to remove the generated |
|
Mailing list message from Thorsten Glaser on jdk8u-dev: On Mon, 19 Feb 2024, Andrew John Hughes wrote:
bye, |
@gnu-andrew : Hi, May I ask if there is a plan to backport JDK-8195689 ? Thanks. |
Hi,
I'd like to backport this patch to jdk8u.
common/autoconf/build-aux/config.guessandhotspot/src/os/linux/vm/os_linux.cppdo not apply cleanly due to context difference, but it is easy to resolve them manually.common/autoconf/platform.m4just changed file path.common/autoconf/generated-configure.shregenerated bybash common/autoconf/autogen.sh.A native build on LoongArch hardware is tested.
Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060236
Loongnix Desktop:
The risk of the downport is low.
Thanks,
Leslie Zhai
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/413/head:pull/413$ git checkout pull/413Update a local copy of the PR:
$ git checkout pull/413$ git pull https://git.openjdk.org/jdk8u-dev.git pull/413/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 413View PR using the GUI difftool:
$ git pr show -t 413Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/413.diff
Webrev
Link to Webrev Comment