-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DEPS: bump pyarrow minimum version from 10.0 to 12.0 #61723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e50fa37
f9389e1
b8bc90e
f16bf76
a6f464a
671fc16
2495ad2
a7cee8a
f7403b3
99ba44f
066af94
6fd257a
23783cb
7ac615f
4d79c27
e5a4626
fef9681
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,9 +8,7 @@ | |
import pyarrow as pa | ||
|
||
_palv = Version(Version(pa.__version__).base_version) | ||
pa_version_under10p1 = _palv < Version("10.0.1") | ||
pa_version_under11p0 = _palv < Version("11.0.0") | ||
pa_version_under12p0 = _palv < Version("12.0.0") | ||
pa_version_under12p1 = _palv < Version("12.0.1") | ||
pa_version_under13p0 = _palv < Version("13.0.0") | ||
pa_version_under14p0 = _palv < Version("14.0.0") | ||
pa_version_under14p1 = _palv < Version("14.0.1") | ||
|
@@ -20,11 +18,9 @@ | |
pa_version_under18p0 = _palv < Version("18.0.0") | ||
pa_version_under19p0 = _palv < Version("19.0.0") | ||
pa_version_under20p0 = _palv < Version("20.0.0") | ||
HAS_PYARROW = True | ||
HAS_PYARROW = _palv >= Version("12.0.1") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I checked the current usages of By changing the definition here, we can use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea. This line could also specify There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I left it as is for now because we would have to update that line anyway when we update the minimum version, and I find the |
||
except ImportError: | ||
pa_version_under10p1 = True | ||
pa_version_under11p0 = True | ||
pa_version_under12p0 = True | ||
pa_version_under12p1 = True | ||
pa_version_under13p0 = True | ||
pa_version_under14p0 = True | ||
pa_version_under14p1 = True | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is for the "Other data sources" section.
As is now also improves performance for a default dtype, should also add to "Performance dependencies (recommended)" section or will this be done in another PR, #61722?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we indeed still have to update our installation guidelines to more prominently recommend installing pyarrow. Will open a separate issue about that (currently tracked it in the list of todo items in #54792)