Skip to content

Translate faq styling #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Conversation

itayyehezkel
Copy link
Collaborator

No description provided.

@tesseralis tesseralis mentioned this pull request May 3, 2019
88 tasks
@netlify
Copy link

netlify bot commented May 3, 2019

Deploy preview for he-reactjs ready!

Built with commit 1c4814d

https://deploy-preview-64--he-reactjs.netlify.com

Copy link
Collaborator

@galnir galnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a suggestion, I think you should translate Styling as עיצוב and not סגנון, it's more accurate imo.
@galtalmor what do you think?

Copy link
Collaborator

@galtalmor galtalmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with Nir that עיצוב is a better fit in most places here.
Also translating inline to בשורה seems a little confusing to me, I would just keep the original.
Other than that, 2 small comments, but really good work!
Thanks!

@itayyehezkel itayyehezkel merged commit 99ba79f into reactjs:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants