Skip to content

Make all?, any? return something more meaningful #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sheerun
Copy link

@sheerun sheerun commented Oct 4, 2016

Currently all of them return nil, what can be confusing when someone comes from JS world.

Also, I'm in need of creating Promise.all? function what returns unscheduled promise of results of all passed promises promises.. The same as Promise.all in JS.

Could we maybe add Promise.all in concurrent ruby as well?

@pitr-ch pitr-ch added the enhancement Adding features, adding tests, improving documentation. label Oct 9, 2016
@pitr-ch pitr-ch added this to the 1.0.4 milestone Oct 9, 2016
@pitr-ch
Copy link
Member

pitr-ch commented Oct 9, 2016

Hi @sheerun, thank you for your feedback. Could you elaborate on the change in this PR, what does the aggregate return now?

The problem you are describing is solved in new implementation of premisses which will deprecate this one. The new implementation is available in edge. The new promises are scheduled for major API renaming update (no internal changes) in few months in edge, then it will be moved to core.

@sheerun
Copy link
Author

sheerun commented Oct 9, 2016

ok then

@sheerun sheerun closed this Oct 9, 2016
@pitr-ch pitr-ch mentioned this pull request Nov 10, 2016
@pitr-ch pitr-ch added the not-applied The bug/enhacement was closed and not fixed/implemented. label Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding features, adding tests, improving documentation. not-applied The bug/enhacement was closed and not fixed/implemented.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants