Address all TODO in v22 #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heading comment for raw_transactions was missing from verify v26. Add it.
Add the struct to types. Add the client macro. Update the table to version, no model is required. Currently untested. Add the reexports.
Add the struct, client macro, test and reexports. Redefine the struct in v25 for added return field. Change to no_model since there is nothing to model.
jamillambert
force-pushed
the
0715-v22-TODOs
branch
from
4a1e783 to
801711c
Compare
tcharding
reviewed
Jul 15, 2025
types/src/v25/wallet.rs
Outdated
| pub internal: Option<bool>, | ||
| /// Defined only for ranged descriptors. | ||
| pub range: Option<[u64; 2]>, | ||
| /// The next index to generate addresses from; defined only for ranged descriptors. |
There was a problem hiding this comment.
Suggested change
| /// The next index to generate addresses from; defined only for ranged descriptors. | |
| /// Same as `next_index` field. Kept for compatibility reason. |
tcharding
reviewed
Jul 15, 2025
types/src/v22/wallet/error.rs
Outdated
| Address(ref e) => Some(e), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't need all this error stuff man, we can just return the address::ParseError directly since there is only one error. I have a vague feeling you added a single field enum recently in some other PR and I missed observing this, correct?
There was a problem hiding this comment.
I have removed the error enum. I'll have a look for the other one.
There was a problem hiding this comment.
Found the other one and removed it in #300
Add the struct, model, client macro, and reexports. Currently untested.
jamillambert
force-pushed
the
0715-v22-TODOs
branch
from
801711c to
805c757
Compare
|
Suggested changes made |
Merged
tcharding
approved these changes
Jul 19, 2025
|
Man I was super confused because there is a docs change in the final patch instead of the one before - I thought I had a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go through all the TODO in the v22 types table. Add all the missing RPCs.
Redefine
listdescriptorsin v25 due to added return field.enumeratesignersandwalletdisplayaddressRPCs require an external signer and have been left untested because of this. Opened #294.