Fix broken KnotInfo URL #40553
Open
Fix broken KnotInfo URL #40553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 1c469d8; changes) is ready! 🎉 |
dcoudert
suggested changes
Aug 8, 2025
src/sage/databases/knotinfo_db.py
Outdated
| at the web-pages `KnotInfo <https://knotinfo.math.indiana.edu/>`__ and | ||
| `LinkInfo <https://linkinfo.sitehost.iu.edu>`__. | ||
| at the web-pages `KnotInfo <https://knotinfo.org/>`__ and | ||
| `LinkInfo <https://https://link-info-repo.onrender.com/>`__. |
There was a problem hiding this comment.
copy/paste error (3 times at least)
There was a problem hiding this comment.
Thanks for reviewing! I've fixed it in the current commit.
dcoudert
suggested changes
Aug 9, 2025
| @@ -317,17 +317,17 @@ def diagram_url(self, fname, single=False): | |||
| sage: from sage.databases.knotinfo_db import KnotInfoDataBase | |||
| sage: ki_db = KnotInfoDataBase() | |||
| sage: ki_db.filename.knots.diagram_url('3_1-50.png') | |||
| 'https://knotinfo.math.indiana.edu/diagram_display.php?3_1-50.png' | |||
| 'https://knotinfo.org/diagram_display.php?3_1-50.png' | |||
There was a problem hiding this comment.
When I try this link, I get a page with
Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/diagram_display.php:1) in /var/www/html/diagram_display.php on line 11
There was a problem hiding this comment.
Interesting! I checked
sage: KnotInfo.K3_1.diagram()
True
which launches the correct site: https://knotinfo.org/diagram_display.php?3_1. The wrong URL is just used on invocation of KnotInfo.K3_1.diagram(single=True). I think these are just outdated doctest and maybe an outdated option in diagram. I will check this later on. If this will lead to a deprecation of this option we should do that in a separate PR.
| sage: ki_db.filename.knots.diagram_url('3_1', single=True) | ||
| 'https://knotinfo.math.indiana.edu/diagrams/3_1' | ||
| 'https://knotinfo.org/diagrams/3_1' |
There was a problem hiding this comment.
I get
Not Found
The requested URL was not found on this server.
src/sage/knots/knotinfo.py
Outdated
| @@ -1359,7 +1359,7 @@ def homfly_polynomial(self, var1='v', var2='z', original=False): | |||
|
|
|||
| The HOMFLY-PT polynomial `P(L)` of a link `L` satisfies the following skein | |||
| relation (see the corresponding `KnotInfo description page | |||
| <https://knotinfo.math.indiana.edu/descriptions/jones_homfly_kauffman_description/polynomial_defn.html)>`__): | |||
| <https://knotinfo.org/descriptions/jones_homfly_kauffman_description/polynomial_defn.html)>`__): | |||
There was a problem hiding this comment.
there is a ) at the end of the url to remove
src/sage/knots/knotinfo.py
Outdated
| @@ -1460,7 +1460,7 @@ def kauffman_polynomial(self, var1='a', var2='z', original=False): | |||
| under regular isotopy `\Delta (L) = a^{w(L)} F(L)` where `w(L)` is the | |||
| writhe of the link `L` satisfies the following skein relation | |||
| (see the corresponding `KnotInfo description page | |||
| <https://knotinfo.math.indiana.edu/descriptions/jones_homfly_kauffman_description/polynomial_defn.html)>`__): | |||
| <https://knotinfo.org/descriptions/jones_homfly_kauffman_description/polynomial_defn.html)>`__): | |||
There was a problem hiding this comment.
remove ) at the end of url
src/sage/knots/knotinfo.py
Outdated
| @@ -1547,7 +1547,7 @@ def jones_polynomial(self, variab=None, skein_normalization=False, puiseux=False | |||
|
|
|||
| The Jones polynomial `V(L)` of a link `L` satisfies the following skein | |||
| relation (see the corresponding `KnotInfo description page | |||
| <https://knotinfo.math.indiana.edu/descriptions/jones_homfly_kauffman_description/polynomial_defn.html)>`__): | |||
| <https://knotinfo.org/descriptions/jones_homfly_kauffman_description/polynomial_defn.html)>`__): | |||
Thanks a lot! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 10, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The URL for KnotInfo currently specified in the Sage documentation (and used by some methods to launch description and image websites, such as `KnotInfo.K6_2.diagram()`) has been disabled. It doesn't even redirect to the [new page](https://knotinfo.org) on [render.com](https://render.com/). This PR implements the URL replacement and points Sage to the current [release 2025.8.7](https://github.com/soehms/database_knotinfo/releases/ tag/2025.8.7) of the Python wrapper. It would be great if this would be merged into 10.7! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40553 Reported by: Sebastian Oehms Reviewer(s): David Coudert, Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-40553: Fix broken KnotInfo URL <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The URL for KnotInfo currently specified in the Sage documentation (and used by some methods to launch description and image websites, such as `KnotInfo.K6_2.diagram()`) has been disabled. It doesn't even redirect to the [new page](https://knotinfo.org) on [render.com](https://render.com/). This PR implements the URL replacement and points Sage to the current [release 2025.8.7](https://github.com/soehms/database_knotinfo/releases/ tag/2025.8.7) of the Python wrapper. It would be great if this would be merged into 10.7! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40553 Reported by: Sebastian Oehms Reviewer(s): David Coudert, Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40553: Fix broken KnotInfo URL <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The URL for KnotInfo currently specified in the Sage documentation (and used by some methods to launch description and image websites, such as `KnotInfo.K6_2.diagram()`) has been disabled. It doesn't even redirect to the [new page](https://knotinfo.org) on [render.com](https://render.com/). This PR implements the URL replacement and points Sage to the current [release 2025.8.7](https://github.com/soehms/database_knotinfo/releases/ tag/2025.8.7) of the Python wrapper. It would be great if this would be merged into 10.7! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40553 Reported by: Sebastian Oehms Reviewer(s): David Coudert, Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 14, 2025
sagemathgh-40553: Fix broken KnotInfo URL <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The URL for KnotInfo currently specified in the Sage documentation (and used by some methods to launch description and image websites, such as `KnotInfo.K6_2.diagram()`) has been disabled. It doesn't even redirect to the [new page](https://knotinfo.org) on [render.com](https://render.com/). This PR implements the URL replacement and points Sage to the current [release 2025.8.7](https://github.com/soehms/database_knotinfo/releases/ tag/2025.8.7) of the Python wrapper. It would be great if this would be merged into 10.7! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40553 Reported by: Sebastian Oehms Reviewer(s): David Coudert, Sebastian Oehms
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 16, 2025
sagemathgh-40553: Fix broken KnotInfo URL <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The URL for KnotInfo currently specified in the Sage documentation (and used by some methods to launch description and image websites, such as `KnotInfo.K6_2.diagram()`) has been disabled. It doesn't even redirect to the [new page](https://knotinfo.org) on [render.com](https://render.com/). This PR implements the URL replacement and points Sage to the current [release 2025.8.7](https://github.com/soehms/database_knotinfo/releases/ tag/2025.8.7) of the Python wrapper. It would be great if this would be merged into 10.7! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40553 Reported by: Sebastian Oehms Reviewer(s): David Coudert, Sebastian Oehms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL for KnotInfo currently specified in the Sage documentation (and used by some methods to launch description and image websites, such as
KnotInfo.K6_2.diagram()) has been disabled. It doesn't even redirect to the new page on render.com.This PR implements the URL replacement and points Sage to the current release 2025.8.7 of the Python wrapper.
It would be great if this would be merged into 10.7!
📝 Checklist
⌛ Dependencies