-
-
Notifications
You must be signed in to change notification settings - Fork 648
Fix broken KnotInfo URL #40553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix broken KnotInfo URL #40553
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5e34119
switch to new URL
soehms 633223c
upgrade package to 2025.8.7
soehms 89179ce
Merge branch 'sagemath:develop' into fix_broken_knotinfo_url
soehms 6e1bacc
40553: fix according to review
soehms 1c469d8
40553: remove wrong bracket from url
soehms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
tarball=database_knotinfo-VERSION.tar.gz | ||
sha1=d94335a4839946e73458064d6ad1def9595101c7 | ||
sha256=9065ec00e22bd1e43716b3e0c2d1bb9e2c32e504a24f11d81ab556428bb4aa7f | ||
sha1=5d9d19ead2d50e7ab6d48fddadb0a7635a9c7ca6 | ||
sha256=5c005386d6f3ffdca3310a1721e377f570272f702a6c81f7d7215fe3935baaf7 | ||
upstream_url=https://files.pythonhosted.org/packages/source/d/database_knotinfo/database_knotinfo-VERSION.tar.gz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2024.10.1 | ||
2025.8.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,8 @@ | |
|
||
This module contains the class :class:`KnotInfoDataBase` and auxiliary classes | ||
for it, which serves as an interface to the lists of named knots and links provided | ||
at the web-pages `KnotInfo <https://knotinfo.math.indiana.edu/>`__ and | ||
`LinkInfo <https://linkinfo.sitehost.iu.edu>`__. | ||
at the web-pages `KnotInfo <https://knotinfo.org/>`__ and | ||
`LinkInfo <https://link-info-repo.onrender.com/>`__. | ||
|
||
To use the database, you need to install the optional :ref:`database_knotinfo | ||
<spkg_database_knotinfo>` package by the Sage command :: | ||
|
@@ -48,8 +48,8 @@ | |
class KnotInfoColumnTypes(Enum): | ||
r""" | ||
Enum class to specify if a column from the table of knots and links provided | ||
at the web-pages `KnotInfo <https://knotinfo.math.indiana.edu/>`__ and | ||
`LinkInfo <https://linkinfo.sitehost.iu.edu>`__. is used for knots only, | ||
at the web-pages `KnotInfo <https://knotinfo.org/>`__ and | ||
`LinkInfo <https://link-info-repo.onrender.com/>`__. is used for knots only, | ||
links only or both. | ||
|
||
EXAMPLES:: | ||
|
@@ -68,8 +68,8 @@ class KnotInfoColumnTypes(Enum): | |
class KnotInfoColumns(Enum): | ||
r""" | ||
Enum class to select a column from the table of knots and links provided | ||
at the web-pages `KnotInfo <https://knotinfo.math.indiana.edu/>`__ and | ||
`LinkInfo <https://linkinfo.sitehost.iu.edu>`__. | ||
at the web-pages `KnotInfo <https://knotinfo.org/>`__ and | ||
`LinkInfo <https://link-info-repo.onrender.com/>`__. | ||
|
||
EXAMPLES:: | ||
|
||
|
@@ -199,7 +199,7 @@ def url(self): | |
sage: from sage.databases.knotinfo_db import KnotInfoDataBase | ||
sage: ki_db = KnotInfoDataBase() | ||
sage: ki_db.filename.knots.url() | ||
'https://knotinfo.math.indiana.edu/' | ||
'https://knotinfo.org/' | ||
""" | ||
if self == KnotInfoFilename.knots: | ||
return self.value[0] | ||
|
@@ -304,7 +304,7 @@ def description_url(self, column): | |
sage: from sage.databases.knotinfo_db import KnotInfoDataBase | ||
sage: ki_db = KnotInfoDataBase() | ||
sage: ki_db.filename.knots.description_url(ki_db.columns().braid_notation) | ||
'https://knotinfo.math.indiana.edu/descriptions/braid_notation.html' | ||
'https://knotinfo.org/descriptions/braid_notation.html' | ||
""" | ||
return '%sdescriptions/%s.html' % (self.url(), column.name) | ||
|
||
|
@@ -317,17 +317,17 @@ def diagram_url(self, fname, single=False): | |
sage: from sage.databases.knotinfo_db import KnotInfoDataBase | ||
sage: ki_db = KnotInfoDataBase() | ||
sage: ki_db.filename.knots.diagram_url('3_1-50.png') | ||
'https://knotinfo.math.indiana.edu/diagram_display.php?3_1-50.png' | ||
'https://knotinfo.org/diagram_display.php?3_1-50.png' | ||
sage: ki_db.filename.knots.diagram_url('3_1', single=True) | ||
'https://knotinfo.math.indiana.edu/diagrams/3_1' | ||
'https://knotinfo.org/diagrams/3_1' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I get
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See the previous issue. |
||
""" | ||
if single: | ||
return '%sdiagrams/%s' % (self.url(), fname) | ||
else: | ||
return '%sdiagram_display.php?%s' % (self.url(), fname) | ||
|
||
knots = ['https://knotinfo.math.indiana.edu/', 'knotinfo_data_complete'] | ||
links = ['https://linkinfo.sitehost.iu.edu/', 'linkinfo_data_complete'] | ||
knots = ['https://knotinfo.org/', 'knotinfo_data_complete'] | ||
links = ['https://link-info-repo.onrender.com/', 'linkinfo_data_complete'] | ||
|
||
|
||
#---------------------------------------------------------------------------------------------------------------------------- | ||
|
@@ -347,7 +347,7 @@ class KnotInfoDataBase(SageObject, UniqueRepresentation): | |
sage: from sage.databases.knotinfo_db import KnotInfoDataBase | ||
sage: ki_db = KnotInfoDataBase() | ||
sage: ki_db.filename.knots | ||
<KnotInfoFilename.knots: ['https://knotinfo.math.indiana.edu/', | ||
<KnotInfoFilename.knots: ['https://knotinfo.org/', | ||
'knotinfo_data_complete']> | ||
""" | ||
|
||
|
@@ -362,7 +362,7 @@ def __init__(self, install=False): | |
sage: from sage.databases.knotinfo_db import KnotInfoDataBase | ||
sage: ki_db = KnotInfoDataBase() | ||
sage: ki_db.filename.links | ||
<KnotInfoFilename.links: ['https://linkinfo.sitehost.iu.edu/', | ||
<KnotInfoFilename.links: ['https://link-info-repo.onrender.com/', | ||
'linkinfo_data_complete']> | ||
""" | ||
# some constants | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try this link, I get a page with
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! I checked
which launches the correct site:
https://knotinfo.org/diagram_display.php?3_1
. The wrong URL is just used on invocation ofKnotInfo.K3_1.diagram(single=True)
. I think these are just outdated doctest and maybe an outdated option indiagram
. I will check this later on. If this will lead to a deprecation of this option we should do that in a separate PR.