-
Notifications
You must be signed in to change notification settings - Fork 35
Move cookiecutter Tofu to new site environment #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, looks structurally sound though!
Co-authored-by: Steve Brasier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, query, no need to rerun CI.
Co-authored-by: Steve Brasier <[email protected]>
looks like it has here https://github.com/stackhpc/ansible-slurm-appliance/blob/feat/site-tofu/cookiecutter/%7B%7Bcookiecutter.environment%7D%7D/ansible.cfg, probably some github diff weirdness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From merge test:
- topology: lets remove from site/groups, and add a note in production to say consider turning this on if cluster is VMs AND its either in one AZ or AZ is configured by rack, and point to docs.
Other than that looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
site
environment to serve as a base environment for all new cookiecutter environments by default.site
to receive upgrades from the upstream Tofu../environments/skeleton
to./cookiecutter
.environments/common/layouts
, theeverything
templates is now thegroups
file of the site environment.site
as a "parent" in their ansible.cfg by default. Their Tofu configuration is a module pointing at thesite
Tofu and they no longer define agroups
file (deferred tosite
)..stackhpc
environment now based on thesite
environment.Note: topology aware scheduling is also now off by default, guidance on re-enabling has been added to the production docs
Warning
Will cause merge conflicts with existing
site
environments. To resolve:environments/site/tofu/variables.tf
, changes should generally be rejectedenvironments/site/tofu
should generally be accepted (unless site specific resources have previously been defined)environments/site/inventory/group_vars/all
should be your existing yaml files:children
of existing groups inenvironments/site/inventory/groups
should generally be rejected. New groups which have been added should generally be accepted, unless the feature the group enables is not desired