Skip to content

Don't set topology plugin if topology group not enabled #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Don't set topology plugin if topology group not enabled #754

merged 1 commit into from
Aug 7, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Aug 7, 2025

The flat topolgy plugin doesn't work:

$ systemctl status slurmctld
error: Couldn't find the specified plugin name for topology/flat looking at all files
slurmctld: error: cannot find topo plugin for topology/flat
slurmctld: error: cannot create topo context for topology/flat
slurmctld: fatal: Failed to initialize topology plugin
error: cannot find topo plugin for topology/flat
error: cannot create topo context for topology/flat
fatal: Failed to initialize topology plugin

Exposed in CI by #751 which turned off topology by default.

@sjpb sjpb force-pushed the fix/no-topology branch from 29f6a47 to 464bd06 Compare August 7, 2025 12:05
@sjpb sjpb marked this pull request as ready for review August 7, 2025 12:06
@sjpb sjpb requested a review from a team as a code owner August 7, 2025 12:06
wtripp180901
wtripp180901 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 4c25181 into main Aug 7, 2025
2 of 4 checks passed
@sjpb sjpb deleted the fix/no-topology branch August 7, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtripp180901 wtripp180901 wtripp180901 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @wtripp180901