Remove the note that suggests using @unchecked
#81738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@unchecked Sendble` is dangerous, and almost always the wrong thing to use. Don't have the compiler suggest it.
DougGregor
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@twostraws this is your fault |
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
Jul 15, 2025
The previous message was just suggesting unchecked Sendable, but instead we should be suggesting to add final to the class. We also don't outright suggest using unchecked Sendable -- following swiftlang#81738 precedent. Resolves rdar://155790695
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
Jul 15, 2025
The previous message was just suggesting unchecked Sendable, but instead we should be suggesting to add final to the class. We also don't outright suggest using unchecked Sendable -- following swiftlang#81738 precedent. Resolves rdar://155790695
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
Jul 16, 2025
The previous message was just suggesting unchecked Sendable, but instead we should be suggesting to add final to the class. We also don't outright suggest using unchecked Sendable -- following swiftlang#81738 precedent. Resolves rdar://155790695
susmonteiro
pushed a commit
to susmonteiro/swift
that referenced
this pull request
Jul 17, 2025
The previous message was just suggesting unchecked Sendable, but instead we should be suggesting to add final to the class. We also don't outright suggest using unchecked Sendable -- following swiftlang#81738 precedent. Resolves rdar://155790695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@unchecked Sendableis dangerous, and almost always the wrong thing to use. Don't have the compiler suggest it.