[Concurrency] add fixit to add final to non-sendable class -> Sendable #83053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
reviewed
Jul 15, 2025
The previous message was just suggesting unchecked Sendable, but instead we should be suggesting to add final to the class. We also don't outright suggest using unchecked Sendable -- following swiftlang#81738 precedent. Resolves rdar://155790695
ktoso
force-pushed
the
pick-better-class-sendable-diagnostic
branch
from
7a74751 to
f52f445
Compare
xedin
approved these changes
Jul 15, 2025
|
@swift-ci please smoke test |
ktoso
commented
Jul 15, 2025
| @@ -5954,8 +5954,7 @@ ERROR(concurrent_value_outside_source_file,none, | |||
| "%kind0; use '@unchecked Sendable' for retroactive conformance", | |||
| (const ValueDecl *)) | |||
| ERROR(concurrent_value_nonfinal_class,none, | |||
| "non-final class %0 cannot conform to 'Sendable'; " | |||
| "use '@unchecked Sendable'", (DeclName)) | |||
| "non-final class %0 cannot conform to the 'Sendable' protocol", (DeclName)) | |||
There was a problem hiding this comment.
the "to the Sendable protocol" rewording because it seems that's how we spell it everywhere else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous message was just suggesting unchecked Sendable, but instead
we should be suggesting to add final to the class. We also don't
outright suggest using unchecked Sendable -- following
#81738 precedent.
Resolves rdar://155790695