[RemoteAddress] Handle comparison of addresses in different spaces #82995
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
kastiglione
reviewed
Jul 11, 2025
kastiglione
reviewed
Jul 11, 2025
mikeash
approved these changes
Jul 11, 2025
kastiglione
reviewed
Jul 11, 2025
| @@ -64,6 +64,11 @@ TypeRefBuilder::ReflectionTypeDescriptorFinder:: | |||
| .TypeReference.startAddress() | |||
| .getRemoteAddress(); | |||
|
|
|||
| // Sort first by address space, then by address. | |||
There was a problem hiding this comment.
oh I guess this is the comment. Should RemoteAddress implement <? Or should this logic be encapsulated somewhere?
There was a problem hiding this comment.
RemoteAddress does implement <, but by default we assert if the address spaces are different. For ordering purposes it makes sense to compare the address space too though, as long as we are consistent.
There was a problem hiding this comment.
I added oderedLessThan and orderedLessThanOrEqual to encapsulate this logic.
augusto2112
force-pushed
the
sort-addresses
branch
from
6e279fc to
89f6a7b
Compare
Sometimes it makes sense to compares addresses from different address spaces. rdar://148361743
augusto2112
force-pushed
the
sort-addresses
branch
from
89f6a7b to
c97dfd6
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it makes sense to compares addresses from different address spaces.
rdar://148361743