Skip to content

[NFC][RemoteInspection] Make MemoryReader::readRemoteAddress virtual #83123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2025
Merged

[NFC][RemoteInspection] Make MemoryReader::readRemoteAddress virtual #83123

merged 2 commits into from
Jul 18, 2025

Conversation

augusto2112
Copy link
Contributor

@augusto2112 augusto2112 commented Jul 17, 2025 •
edited
Loading

@augusto2112
[NFC][RemoteMirrors] Add "template" in front of calls to readRemoteAd…
ac62ffc 
…dress

(cherry picked from commit 16591e4)
@augusto2112
[RemoteInspection] Make MemoryReader::readRemoteAddress virtual
2ec8f05 
Allow subclasses to override the behavior of readRemoteAddress. LLDB in
particular needs this to correctly set the address space of the result
remote address.

rdar://148361743
(cherry picked from commit 45d6d45)
@augusto2112
Copy link
Contributor Author

swiftlang/llvm-project#11016
@swift-ci test

@augusto2112 augusto2112 mentioned this pull request Jul 17, 2025
Merged
@augusto2112 augusto2112 changed the title Virtual read remote addr 6.2 [Draft]Virtual read remote addr 6.2 Jul 17, 2025
@augusto2112
Copy link
Contributor Author

swiftlang/llvm-project#11016
@swift-ci test

2 similar comments
@augusto2112
Copy link
Contributor Author

swiftlang/llvm-project#11016
@swift-ci test

@augusto2112
Copy link
Contributor Author

swiftlang/llvm-project#11016
@swift-ci test

@augusto2112 augusto2112 changed the title [Draft]Virtual read remote addr 6.2 [NFC][RemoteInspection] Make MemoryReader::readRemoteAddress virtual Jul 18, 2025
@augusto2112 augusto2112 marked this pull request as ready for review July 18, 2025 18:10
@augusto2112 augusto2112 requested a review from a team as a code owner July 18, 2025 18:10
@augusto2112 augusto2112 requested a review from fredriss July 18, 2025 18:10
@fredriss fredriss merged commit b8da06d into swiftlang:release/6.2 Jul 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredriss fredriss fredriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augusto2112 @fredriss