fix(signinup): several issues #12698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AMoreaux
commented
Jun 18, 2025
AMoreaux
commented
- Fixed an issue where you have invitations in your available workspaces for signup.
- Corrected the URL display in the browser when hovering over the twenty logo on the sign-in/up form.
- The workspace list is now displayed when you are logged into the default domain.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Comprehensive updates to workspace authentication and domain handling during sign-in/up flow.
- Added
defaultUrltouseReadDefaultDomainFromConfigurationhook to maintain URL parameters and protocol during domain redirection - Enhanced
UserWorkspaceServiceto handle nullworkspaceSSOIdentityProvidersand include both personal invite token and workspace'sinviteHash - Updated Logo component to use dynamic
defaultUrlinstead of hardcodedAppPath.SignInUp - Fixed workspace selection logic in
SignInUpGlobalScopeFormEffectto properly handle multiple available workspaces - Simplified state management in SignInUp component by leveraging
useAuthhook
5 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| @@ -6,6 +6,7 @@ import { UndecoratedLink } from 'twenty-ui/navigation'; | |||
| import { REACT_APP_SERVER_BASE_URL } from '~/config'; | |||
| import { useRedirectToDefaultDomain } from '~/modules/domain-manager/hooks/useRedirectToDefaultDomain'; | |||
| import { AppPath } from '~/modules/types/AppPath'; | |||
| import { useReadDefaultDomainFromConfiguration } from '@/domain-manager/hooks/useReadDefaultDomainFromConfiguration'; | |||
There was a problem hiding this comment.
style: Import path should use '~' alias instead of '@' for consistency with other imports
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:38826 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jun 18, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 18, 2025
- Fixed an issue where you have invitations in your available workspaces for signup. - Corrected the URL display in the browser when hovering over the twenty logo on the sign-in/up form. - The workspace list is now displayed when you are logged into the default domain.
|
Sentry Issue: TWENTY-SERVER-6DE |
Weiko
pushed a commit
that referenced
this pull request
Jun 19, 2025
ijreilly
added a commit
that referenced
this pull request
Jun 19, 2025
ehconitin
pushed a commit
to ehconitin/twenty
that referenced
this pull request
Jun 19, 2025
This reverts commit 9612a49. (Causes a google auth sign-up issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.