Revert "fix(signinup): several issues (#12698)" #12745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9612a49.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reverts recent sign-in/up fixes due to a Google auth sign-up issue, impacting several key authentication components:
- Modified workspace provider handling in
user-workspace.service.tsby removing optional chaining, which could cause runtime errors with undefined providers - Reverted domain configuration in
useReadDefaultDomainFromConfiguration.ts, removing URL construction logic for defaultUrl - Simplified sign-in flow in
SignInUpGlobalScopeFormEffect.tsxby removing workspace availability checks - Changed logo click behavior in
SignInUp.tsxto return to Init step instead of signing out
Warning: These changes may reintroduce issues the original PR (#12698) was meant to fix.
5 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
prastoin
approved these changes
Jun 19, 2025
ijreilly
added a commit
that referenced
this pull request
Jun 19, 2025
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:23932 This environment will automatically shut down when the PR is closed or after 5 hours. |
ehconitin
pushed a commit
to ehconitin/twenty
that referenced
this pull request
Jun 19, 2025
This reverts commit 9612a49. (Causes a google auth sign-up issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9612a49.
(Causes a google auth sign-up issue)