[Permissions] Force open title input for role label when empty

[Weiko]

• Fix empty title in breadcrumb
• Enforce role label input open if empty

[greptile-apps]

PR Summary

Introduces Recoil-based state management for title inputs with enforced open state for empty role labels, improving UX and consistency across the application.

• Added new titleInputComponentState with instance isolation using Recoil, replacing local React state in TitleInput.tsx
• Created SettingsRoleLabelContainerEffect to enforce open state for empty role labels, following side-effect pattern
• Standardized empty role label placeholder text to 'Untitled Role' across components
• Added unique instanceId prop requirement for TitleInput components to support isolated state management

_{10 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

style: Empty fragment not needed since this is an effect component, use null instead

[prastoin]

Nice job ! About to test locally

[prastoin]

Subjectives thoughts/questions: Could the user insert an empty string ? From my understanding this assertion aims to compare if the current value is the default one ?
Would it makes sense for you to do such a thing ?

// packages/twenty-front/src/modules/settings/roles/states/settingsDraftRoleFamilyState.ts
export const settingsDraftRoleFamilyStateDefaultValue ={
    id: '',
    label: '',
    description: '',
    icon: '',
    canDestroyAllObjectRecords: false,
    canReadAllObjectRecords: false,
    canSoftDeleteAllObjectRecords: false,
    canUpdateAllObjectRecords: false,
    canUpdateAllSettings: false,
    isEditable: false,
    workspaceMembers: [],
    settingPermissions: [],
    objectPermissions: [],
} as const
export const settingsDraftRoleFamilyState = createFamilyState<Role, string>({
  key: 'settingsDraftRoleFamilyState',
  defaultValue: settingsDraftRoleFamilyStateDefaultValue
});

// packages/twenty-front/src/modules/settings/roles/role/components/SettingsRole.tsx
if (settingsDraftRole.label === settingsDraftRoleFamilyStateDefaultValue.label && !isTitleInputOpen) {

[prastoin]

Nitpick: Unless I'm mistaken could use isNonEmptyString

[prastoin]

Remarks

While testing locally I encountered two "weird' behaviors. The role label enforcement prevents:

• To send the form but it seems like the form would be passing validation as the save CTA is active ( tho on the video no http request is performed from it being clicked )

Screen.Recording.2025-06-19.at.15.26.29.mov

• It takes precedance over other form inputs from same and other tabs ( description see above video )

Screen.Recording.2025-06-19.at.15.29.32.mov