Revert "[Permissions] Force open title input for role label when empty" #12817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reverts automatic title input opening for empty role labels, removing several state management components and simplifying the code architecture.
- Removes entire
titleInputComponentState.tsandtitleInputComponentInstanceContext.tsfiles, eliminating Recoil-based state management for title input control - Removes
instanceIdprop usage fromTitleInputcomponent, affectingWorkflowStepHeaderand settings components - Changes placeholder text from 'Untitled Role' back to 'Role name' in multiple components
- Removes automatic input opening behavior when role labels are empty, requiring explicit user interaction
- Deletes
SettingsRoleLabelContainerEffect.tsxwhich previously handled empty label detection and auto-opening
10 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| ) : ( | ||
| <StyledUntitledRole>{t`Untitled Role`}</StyledUntitledRole> | ||
| ), | ||
| children: settingsDraftRole.label, |
There was a problem hiding this comment.
logic: No fallback display when label is empty. Consider showing 'Untitled Role' or similar placeholder.
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:40834 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12710