-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove number from label identifier list #12831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove number from label identifier list #12831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Removes FieldMetadataType.NUMBER
from label identifier types, restricting record identifiers to only text and full name fields. This change aligns the data model with its usage as record text in the UI.
- Removed
NUMBER
fromLABEL_IDENTIFIER_FIELD_METADATA_TYPES
insrc/modules/object-metadata/constants/LabelIdentifierFieldMetadataTypes.ts
- Improved type safety by replacing
!!
operator withisDefined
utility inSettingsObjectFieldActiveActionDropdown
- This is a breaking change that may affect existing implementations using number fields as record identifiers
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
...ages/twenty-front/src/modules/object-metadata/constants/LabelIdentifierFieldMetadataTypes.ts
Show resolved
Hide resolved
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:20663 This environment will automatically shut down when the PR is closed or after 5 hours. |
ff8ff22
to
a13fe17
Compare
@greptileai trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Major validation and backend implementation updates for label identifier changes, focusing on ensuring only text-based fields can be used as identifiers.
- Added
validateMetadataIdentifierFieldMetadataId
utility to enforce label/image identifier validation insrc/engine/metadata-modules/utils/validate-metadata-identifier-field-metadata-id.utils.ts
- Implemented unicity row hook in
spreadsheetImportGetUnicityRowHook.ts
to properly validate unique constraints during data imports - Added comprehensive error tracking with MetricsService integration across GraphQL operations and workflow executions
- Migrated several database queries from TypeORM to direct SQL via WorkspaceDataSourceService for better performance
- Updated 30+ localization files to reflect new workspace creation and data model terminology
118 files reviewed, 5 comments
Edit PR Review Bot Settings | Greptile
Introduction
closes #12780
Removed the number field metadata from the selectable field metadata as identifier
Implemented server side validation and basic coverage on that