Skip to content

accumulate: remove Lisp-specific portion #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2017
Merged

accumulate: remove Lisp-specific portion #871

merged 1 commit into from
Aug 9, 2017

Conversation

petertseng
Copy link
Member

@petertseng petertseng commented Aug 3, 2017

Elixir-specific portion added:
exercism/exercism#1136

Lisp-specific portion added:
#98

Elixir-specific portion removed because the Enum.reduce was not
necessary:
#274

The reason to suggest removing this Lisp-specific now is slightly
different:
It doesn't seem to make much sense to include this Lisp-specific
sentence in non-Lisp tracks.

See that http://x.exercism.io/problems/accumulate indicates this
exercise is only implemented by one Lisp-like language (Clojure) and 19
non-Lisp-like languages.

It could be possible for the tracks that desire this clause to place it
in .meta/HINTS.md. It is easy to add content to the description.md,
but it is not easy to remove content. Leaving the content in
description.md is potentially asking 19 different tracks to take custom
measures to remove it (an exercise-specific template), unless we come up
with a better way to remove content (a .patch to be applied to each
description.md, perhaps).

It is acknowledged that
#129 indicates
the exercise will be deprecated at a point in the future. Nevertheless,
it is still true that the exercise exists, and that new implementations
for it are being contributed (exercism/rust#332)
and that this README change benefits those tracks that have this
exercise.

Elixir-specific portion added:
exercism/exercism#1136

Lisp-specific portion added:
#98

Elixir-specific portion removed because the `Enum.reduce` was not
necessary:
#274

The reason to suggest removing this Lisp-specific now is slightly
different:
It doesn't seem to make much sense to include this Lisp-specific
sentence in non-Lisp tracks.

See that http://x.exercism.io/problems/accumulate indicates this
exercise is only implemented by one Lisp-like language (Clojure) and 19
non-Lisp-like languages.

It could be possible for the tracks that desire this clause to place it
in .meta/HINTS.md. It is easy to **add** content to the description.md,
but it is not easy to **remove** content. Leaving the content in
description.md is potentially asking 19 different tracks to take custom
measures to remove it (an exercise-specific template), unless we come up
with a better way to **remove** content (a .patch to be applied to each
description.md, perhaps).

It is acknowledged that
#129 indicates
the exercise will be deprecated at a point in the future. Nevertheless,
it is still true that the exercise exists, and that new implementations
for it are being contributed (exercism/rust#332)
and that this README change benefits those tracks that have this
exercise.
@ErikSchierboom ErikSchierboom merged commit 3793e23 into exercism:master Aug 9, 2017
@petertseng petertseng deleted the acc-lisp branch August 22, 2017 06:17
ijanos pushed a commit to exercism/rust that referenced this pull request Sep 1, 2017
Elixir-specific portion added:
exercism/exercism#1136

Lisp-specific portion added:
exercism/problem-specifications#98

Elixir-specific portion removed because the `Enum.reduce` was not
necessary:
exercism/problem-specifications#274

It doesn't seem to make much sense to include this Lisp-specific
sentence in non-Lisp tracks.

exercism/problem-specifications#871
petertseng added a commit to exercism/haskell that referenced this pull request Sep 8, 2017
Elixir-specific portion added:
exercism/exercism#1136

Lisp-specific portion added:
exercism/problem-specifications#98

Elixir-specific portion removed because the `Enum.reduce` was not
necessary:
exercism/problem-specifications#274

It doesn't seem to make much sense to include this Lisp-specific
sentence in non-Lisp tracks.

exercism/problem-specifications#871
emcoding pushed a commit that referenced this pull request Nov 19, 2018
change: Update generator & Regenerate Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants