Skip to content

C++: Import AST GVN module for tests #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Conversation

MathiasVP
Copy link
Contributor

Fixes imports of two GVN tests. The tests imported the module that change depending on whether or not the IR is enabled. This affected the output from GVN tests in #2851.

@MathiasVP MathiasVP added the C++ label Feb 18, 2020
@MathiasVP MathiasVP requested a review from a team as a code owner February 18, 2020 11:26
@jbj
Copy link
Contributor

jbj commented Feb 18, 2020

LGTM, but it'll cause a semantic merge conflict with #2851, so we can't merge this yet.

@jbj
Copy link
Contributor

jbj commented Feb 19, 2020

@MathiasVP Please merge master into this PR and update the expected files.

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants