Skip to content

C++: Fix a test that should be working on the AST dataflow. #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Feb 19, 2020

Following #2851 there were some AST tests that now test the IR instead (because that's the new default) when they shouldn't. #2861 fixed the diff tests. This fixed an explicit AST taint test in library-tests\dataflow\security-taint (the same directory contains an IR taint test and a diff between the two).

@geoffw0 geoffw0 added the C++ label Feb 19, 2020
@geoffw0 geoffw0 requested a review from a team as a code owner February 19, 2020 13:06
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdmarsh2 rdmarsh2 merged commit 82f2540 into github:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants