-
Notifications
You must be signed in to change notification settings - Fork 0
chore: bumps alloy and zenith versions #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dylanlott
commented
Jan 10, 2025
- bump alloy up
- remove alloy primitives and import primitives from alloy core instead
- fix errors from alloy updates
- remove signet-types and reference zenith-types instead
This stack of pull requests is managed by Graphite. Learn more about stacking. |
- bump alloy up - remove alloy primitives and import primitives from alloy core instead - fix errors from alloy updates - remove signet-types and reference zenith-types instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit:
aedbf4d
to
3b0c97b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. just some last few nits. also, commits are still unverified, for some reason
//! Bundler service responsible for polling and submitting bundles to the in-progress block. | ||
use std::time::{Duration, Instant}; | ||
//! Bundler service responsible for managing bundles. | ||
use super::oauth::Authenticator; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the blank line
use alloy_primitives::map::HashMap; | ||
use reqwest::Url; | ||
use serde::{Deserialize, Serialize}; | ||
use signet_types::SignetEthBundle; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -2,8 +2,8 @@ mod tests { | |||
use std::str::FromStr; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto