Skip to content

fix: use an async http client #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: use an async http client #44

merged 1 commit into from
Jan 10, 2025

Conversation

dylanlott
Copy link
Contributor

  • changes the oauth fetcher to use an async http client to play nice with tokio during tests

@dylanlott Graphite App
Copy link
Contributor Author

dylanlott commented Jan 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott marked this pull request as ready for review January 10, 2025 19:14
@dylanlott dylanlott mentioned this pull request Jan 10, 2025
Merged
@dylanlott dylanlott mentioned this pull request Jan 10, 2025
Merged
@dylanlott dylanlott force-pushed the dylan/bump-alloy-zenith branch from aedbf4d to 3b0c97b Compare January 10, 2025 19:49
@dylanlott dylanlott force-pushed the dylan/async-http-client branch 2 times, most recently from 70eb141 to dbd451d Compare January 10, 2025 19:52
@dylanlott dylanlott changed the base branch from dylan/bump-alloy-zenith to graphite-base/44 January 10, 2025 20:07
@dylanlott dylanlott force-pushed the dylan/async-http-client branch from dbd451d to cab238a Compare January 10, 2025 20:08
@dylanlott dylanlott changed the base branch from graphite-base/44 to main January 10, 2025 20:08
@dylanlott
fix: use an async http client
2c9f717 
- changes the oauth fetcher to use an async http client to play nice with tokio during tests
@dylanlott dylanlott force-pushed the dylan/async-http-client branch from cab238a to 2c9f717 Compare January 10, 2025 20:08
@dylanlott dylanlott self-assigned this Jan 10, 2025
@dylanlott dylanlott merged commit f1ea58e into main Jan 10, 2025
5 checks passed
@dylanlott dylanlott deleted the dylan/async-http-client branch January 10, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees

@dylanlott dylanlott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @Evalir